[Workflow] Use subject to fetch state_machine #9613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Apr 18, 2018
There was a problem hiding this comment.
Good catch! The code is clear about this: https://github.com/symfony/workflow/blob/195fc22bc7591528a5f769c2c75f12203e16afed/Registry.php#L49 Thanks for fixing it and congrats on your first Symfony Docs contribution!
javiereguiluz
added a commit
that referenced
this pull request
Apr 18, 2018
This PR was merged into the 4.0 branch. Discussion ---------- [Workflow] Use subject to fetch state_machine Not using the subject to fetch the stateMachine will throw an ErrorException because the first argument passed to the get-method is a string and not an object. Commits ------- 279a9c1 [Workflow] Use subject to fetch state_machine
|
Thanks @javiereguiluz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using the subject to fetch the stateMachine will throw an ErrorException because the first argument passed to the get-method is a string and not an object.